fix: remove unnecessary qos data record form pcc ruls #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #627.
Upon tracing, I found that the default PCC rule created by the PCF contains nil QoS data, which is transformed into a new QoS rule with QFI=2. This is unnecessary and redundant. However, there is two pieces of data required by the SMF: the default charging data. Therefore, it is not necessary to store this default PCC rule in
smContext.PCCRules
after extracting the charging data.In the original code, if a customized flow rule is set via the web console, two additional QoS flows are added to
smContext.AdditionalQosFlows
. These include one default PCC rule and the customized rule based on the decision made by the PCF. With this update, I discard the default PCC rule and retain only the customized rules. This ensures that the number ofQoSDescriptions
and the items inQosFlowSetupRequestList
in the NAS packet are accurate.Changes Made:
QoSID
(indicating no QoS data), it will not allocate a QFI to it.QoSID
(indicating QoS data) are stored and appended tosmContext.AdditionalQosFlows
as QoS rules.I have tested that with this modification, traffic and charging remain functional as before.