Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glob behaviour #422

Merged
merged 7 commits into from
Sep 16, 2023
Merged

Fix glob behaviour #422

merged 7 commits into from
Sep 16, 2023

Conversation

ap--
Copy link
Contributor

@ap-- ap-- commented Sep 7, 2023

Hello everyone,

I noticed that fsspec==2023.9.0 fixed the way .glob() handles "**" patterns. fsspec/filesystem_spec#1329
This PR updates adlfs to rely on fsspec's newer glob implementation.

I opted for bumping the minimum required fsspec version, but this could also be handled by vendoring the newer fsspec glob implementations for older fsspec versions.

Let me know if you'd prefer the other, and I can change the PR.

Cheers,
Andreas 😃

@TomAugspurger
Copy link
Contributor

Thanks for the PR. I agree with the decision to bump the minimum version of fsspec.

Looking at fsspec/filesystem_spec#1329, it seems there are quite a few issues linking to it, so this is a disruptive change. But maintaining compatibility with fsspec is the most important thing here. Hopefully we don't ever have to change the behavior of glob again.

I'll merge once this is green.

@TomAugspurger TomAugspurger merged commit a1b8b52 into fsspec:main Sep 16, 2023
4 checks passed
@TomAugspurger
Copy link
Contributor

Thanks @ap--! I'll look into a getting a release out soon.

@ap-- ap-- deleted the fix-glob branch September 16, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants