Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
I noticed that
fsspec==2023.9.0
fixed the way.glob()
handles "**" patterns. fsspec/filesystem_spec#1329This PR updates
adlfs
to rely on fsspec's newer glob implementation.I opted for bumping the minimum required fsspec version, but this could also be handled by vendoring the newer fsspec glob implementations for older fsspec versions.
Let me know if you'd prefer the other, and I can change the PR.
Cheers,
Andreas 😃