Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vep 101.0 v1 #6

Merged
merged 4 commits into from
Feb 3, 2021
Merged

Vep 101.0 v1 #6

merged 4 commits into from
Feb 3, 2021

Conversation

chrisamiller
Copy link
Collaborator

updating to version 101, removing unneeded scripts

@susannasiebert
Copy link
Contributor

Before merging this in and using, we need to be aware, that this update causes differences in the Downstream plugin annotation for pVACseq (see griffithlab/pVACtools#576 and Ensembl/VEP_plugins#342). We will need to fix pVACseq and require input VCFs to pVACseq to be annotated with VEP >= 100 + --hgvs option.

I think we should carefully test this VEP version and look at the Downstream annotations produced by this verion + --hgvs option and check that none of them include the leading Downstream wildtype amino acid.

@susannasiebert
Copy link
Contributor

We might also want to check some of the existing VEP 95 Downstream predictions to see if all of them include the leading wildtype amino acid that pVACseq currently expects. This won't really change much going forward but would maybe help us understand this problem better.

Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
After talking with Chris, we will merge this version since the Docker container exists and is already in use in our CWLs. I will make a PR for a V2 version that will add a new plugin Frameshift to address the problem with frameshift downstream predictions.

@chrisamiller chrisamiller merged commit 8966101 into master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants