-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate and rank SNVs per family #502
base: dev
Are you sure you want to change the base?
Annotate and rank SNVs per family #502
Conversation
5c783b3
to
2e36008
Compare
279ecc2
to
2dbe94d
Compare
edf2162
to
c20890e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny typo and one question:
why not make a switch for this?
Removed support for automatically creating an echvar database with SNVs and INDELs, since this requires all variants to be combined into one VCF. Might add this back into the future.
Co-authored-by: Lucía Peña-Pérez <[email protected]>
My idea initially was that it would be nice if you could create a reference database or panel of normals while running the pipeline. For SNVs and INDELs, yes it would be fairly easy to make a switch. But we need to add a module to merge VCFs together before creating a database (and then it should really be a workflow). But for creating SVs, CNVs, STRs and methylation databases we would need a different merging strategies. It would perhaps be nice, but I need to think about it some more. It might work for a 100 samples, but perhaps you would never want to start 1000+ samples at once, and then creating the databases within the pipeline becomes unnecessary, because you would need to combine samples from multiple pipeline runs anyway. In short, I'm removing the functionality because it's easier at the moment. It's not something that we need in production, and not something I'm sure is desirable to have in the pipeline in the future. |
This PR:
sample
andfamily
for all variantsifEmpty
. This is because these error messages would always show up when you had an error, even if that error was unrelated.containts_affected
logic from the snv-calling workflow, since this was previously changed to be checked before pipeline start, and is now done in one of the functions described in point 3.Closes #501 and #276.
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).