Add handling for line type in vector layer #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
martinRenou
reviewed
Sep 17, 2024
| : '#F092DD' | ||
| : layerParameters.type === 'line' | ||
| ? 'rgba(0, 0, 0, 0)' | ||
| : '#F092DD' |
There was a problem hiding this comment.
Should we really keep that #F092DD default?
I'm not sure I understand in which case this #F092DD value will be used
There was a problem hiding this comment.
Should we really keep that #F092DD default?
I'm not sure I understand in which case this #F092DD value will be used
I kept it for just in case 😅. However the above conditional logic covers all existing types. I'm happy to remove it.
There was a problem hiding this comment.
Cool :) Let's clean it up then :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #141
jgis-color.mov
Line type should not be filled which was previously filled with default
#F092DDcolor. This PR adds the handling to set transparent color for line type in Vector layer styling.