Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for line type in vector layer #143

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Add handling for line type in vector layer #143

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f19a2c6
Add handling for line type in vector layer
arjxn-py Sep 16, 2024
f6fe566
Lint
arjxn-py Sep 16, 2024
8b4b30e
Clean it up :broom:
arjxn-py Sep 17, 2024
7da6253
Merge branch 'main' into geojson-color
arjxn-py Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/base/src/mainview/mainView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,9 @@ export class MainView extends React.Component<IProps, IStates> {
color:
layerParameters.type === 'fill' || layerParameters.type === 'circle'
? layerParameters.color
: '#F092DD'
: layerParameters.type === 'line'
? 'rgba(0, 0, 0, 0)'
: '#F092DD'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really keep that #F092DD default?

I'm not sure I understand in which case this #F092DD value will be used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really keep that #F092DD default?

I'm not sure I understand in which case this #F092DD value will be used

I kept it for just in case 😅. However the above conditional logic covers all existing types. I'm happy to remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool :) Let's clean it up then :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

});

const stroke = new Stroke({
Expand Down
Loading