-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save records on creation/duplication and allow attachments #1107
Conversation
88cb3f8
to
5e88452
Compare
Affected libs:
|
📷 Screenshots are here! |
6b27bdf
to
3739173
Compare
d561f17
to
4a313ad
Compare
4a313ad
to
d3cd4bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that :) It was because the "/create" page was loaded for a very short time, because "/edit" was not ready yet. I have added a loading spinner to display the "/edit" page only when it has a record ready, it should be smoother. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cmoinier for this huge feature! It was a lot of work and you completed it! 🎉
The code looks good, I just have a few comments and questions. I did not test the feature yet though. Let me know if something is not clear.
Thanks again for your hard work on this!
b7b3fe4
to
04bd352
Compare
f9d84b9
to
e1f5ed4
Compare
e1f5ed4
to
958b57b
Compare
First of!
This PR is a joint work of the record creation & duplication tickets, to allow saving the record and adding attachments in both cases.
A huge thanks to @Angi-Kinas @tkohr @ronitjadhav for the joint work on this PR!
Description
This PR makes sure the attachments are available upon record creation & duplication
To this aim, all newly created/duplicated records are now saved but not published. They can be manually published even without any changes done to the new draft.
A new Observable manages that, named
savedButNotPublished
which carries the information given by the backend for each record, from a search request.The column "Status" of the dashboard is now also based on the response from the search request, and displays the right info.
It is now impossible in all cases to delete from the draft table (since all drafts have a record).
Multiple UT & e2e have been reworked and/or deleted, since the "draft only" status does not exist anymore.
Architectural changes
savedButNotPublished
but no component needs it for now.Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label