Treat undefined properties as if they don't exist #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an issue that arises when validating JS objects rather than objects that have come straight from JSON. Properties that are undefined should be treated as if they had undergone a JSON stringify/parse roundtrip: they should be considered invisible when doing validation. This matches the behavior of other JSON Schema validators that I have tested.
|
I just realized that this is a dupe of #175. |
|
@geraintluff this is important fix. Could you please merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue that arises when validating JS objects rather than objects that have come straight from JSON. Properties that are undefined should be treated as if they had undergone a JSON stringify/parse roundtrip: they should be considered invisible when doing validation. This matches the behavior of other JSON Schema validators that I have tested.
I understand if you disagree with this stance. Perhaps you wish to treat data that would not be expressible as JSON as not being valid.