Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat undefined properties as if they don't exist #220

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Treat undefined properties as if they don't exist #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83cffaa
Treat undefined properties as if they don't exist
Oct 22, 2015
2b60d74
Move typeof check earlier to also fix enums with undefined data
Dec 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions source/basic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
ValidatorContext.prototype.validateBasic = function validateBasic(data, schema, dataPointerPath) {
if (typeof data === "undefined") {
return null;
}
var error;
if (error = this.validateType(data, schema, dataPointerPath)) {
return error.prefixWith(null, "type");
Expand Down
12 changes: 12 additions & 0 deletions test/all_concat.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/all_concat.js.map
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 12 additions & 0 deletions test/tests/05 - Objects/03 - properties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,16 @@ describe("Objects 03", function () {
var valid = tv4.validate(data, schema);
assert.isFalse(valid);
});

it("undefined key success", function () {
var data = {undefinedKey: undefined};
var schema = {
properties: {
undefinedKey: {"type": "integer"}
}
};
var valid = tv4.validate(data, schema);
assert.isTrue(valid);
});

});
3 changes: 3 additions & 0 deletions tv4.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,9 @@ function recursiveCompare(A, B) {
}

ValidatorContext.prototype.validateBasic = function validateBasic(data, schema, dataPointerPath) {
if (typeof data === "undefined") {
return null;
}
var error;
if (error = this.validateType(data, schema, dataPointerPath)) {
return error.prefixWith(null, "type");
Expand Down
2 changes: 1 addition & 1 deletion tv4.min.js
View file
Open in desktop

Large diffs are not rendered by default.