Scanner does not rescan

[ahtrotta]

Fixes #1331

A recent change to @appland/scanner caused a test in vscode-appland to fail most of the time in CI, which has been causing a lot of build failures (builds fail ~75% of the time):

1 failing
  1) Scanner
       is performed as AppMaps are modified:
     Error: No Diagnostics were created for Microposts_controller_can_get_microposts_as_JSON
  	at waitFor (out/test/waitFor.js:35:23)
  	at async repeatUntil (out/test/waitFor.js:7:9)
  	at async Context.<anonymous> (out/test/integration/scanner/performAsAppMapsAreModified.test.js:55:9)

After a lot of testing, I've traced this to @appland/scanner version 1.82.0. The scanner is not re-scanning and is not regenerating the appmap-findings.json file in the test. I haven't been able to figure out exactly why this code change is causing this problem, but this is taking a long time to troubleshoot and it's difficult to run a custom version of the scanner in CI (this PR has an attempt to use appmap-js as a gitmodule but it didn't work), so I think we should just revert the offending commit.

[kgilpin]

But why?

We should have a theory of what’s going wrong? This PR fixes a lot of redundant re-parsing of queries.

[ahtrotta]

But why?

We should have a theory of what’s going wrong? This PR fixes a lot of redundant re-parsing of queries.

Okay, I'll keep trying to figure this out

[kgilpin]

See #1334

[ahtrotta]

Fixed by #1334