fix: Tree provider uniqueness #930
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppMap collections / sub-groups are non-unique due to lack of a defined id, and therefore replicated across all projects in a workspace. This PR groups appmaps uniquely within tree items.
kgilpin
commented
Mar 29, 2024
| const lightChangedIcon = join(__dirname, '../images/modified-file-icon-dark.svg'); | ||
| const darkChangedIcon = join(__dirname, '../images/modified-file-icon-light.svg'); | ||
| // const lightChangedIcon = join(__dirname, '../images/modified-file-icon-dark.svg'); | ||
| // const darkChangedIcon = join(__dirname, '../images/modified-file-icon-light.svg'); |
There was a problem hiding this comment.
This PR is WIP, I will add this back in.
kgilpin
commented
Mar 29, 2024
| const listItems = this.appmaps | ||
| .appMaps() | ||
| .filter((appMap) => | ||
| isDeepStrictEqual(AppMapTreeDataProvider.appMapFolderItems(appMap), folderProperties) |
There was a problem hiding this comment.
This method doesn't distinguish AppMaps by what project they are in. It collects all AppMaps that have the same "folderProperties", but the project in which the AppMap is defined is not one of those properties. Therefore, AppMaps get duplicated across workspace projects in the tree view.
kgilpin
commented
Mar 29, 2024
src/tree/appMapTreeDataProvider.ts
Outdated
| } | ||
| } | ||
|
|
||
| private getTopLevelTreeItems() { | ||
| const projects = vscode.workspace.workspaceFolders; | ||
| if (!projects || this.appmaps.appMaps().length === 0) return []; | ||
|
|
||
| const appmapsByProject = new Map<vscode.WorkspaceFolder, AppMapLoader[]>(); | ||
| const projectsWithAppMaps = this.appmaps.allAppMaps().reduce((projectsWithAppMaps, appmap) => { |
There was a problem hiding this comment.
TODO: Should be appmaps.appMaps(), no?
kgilpin
force-pushed
the
fix/tree-provider-uniqueness
branch
from
7de7272 to
a1da37e
Compare
|
I still haven't gotten around to fixing this. It affects VSCode users with multi-project workspaces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Note the inclusion of the same AppMaps in two different projects:
Solution
AppMaps no longer replicated across projects: