Toggling visibility is now ignored when in fullscreen mode. #5472
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One open question I have @mitchellh is regarding the Show/Hide menu. With this implementation the menu does nothing, including show/hide of any other Ghostty windows. If you prefer, we could only ignore the fullscreen windows while still toggling other open windows that are not fullscreen.. Multi-screen setups may prefer an alternative where we still hide non-fullscreen windows. Let me know which way you'd like to go and I can update 👌 It's a relatively small edit to make the more complex scenario work but I felt this was a reasonable default. Appreciate your feedback 👍 |
mitchellh
requested changes
Feb 1, 2025
|
@mitchellh addressed all comments, should be ready to go 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures visibility toggling is ignored when the currently focused surface is fullscreen. This includes the following:
This ensures Ghostty doesn't unexpectedly lose focus or disappear and is the expected behavior on macOS.