Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling visibility is now ignored when in fullscreen mode. #5472

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −0
Open

Toggling visibility is now ignored when in fullscreen mode. #5472

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95003a7
Toggling visibility is now ignored when in fullscreen mode.
shaps80 Jan 31, 2025
3054137
Updates as per review
shaps80 Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions macos/Sources/App/macOS/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,11 @@ class AppDelegate: NSObject,
}

/// Toggles visibility of all Ghosty Terminal windows. When hidden, activates Ghostty as the frontmost application
///
/// - Note: When the focused surface is fullscreen, this method does nothing.
shaps80 marked this conversation as resolved.
Show resolved Hide resolved
@IBAction func toggleVisibility(_ sender: Any) {
guard terminalManager.focusedSurface?.window?.styleMask.contains(.fullScreen) == false else { return }
shaps80 marked this conversation as resolved.
Show resolved Hide resolved

// If we have focus, then we hide all windows.
if NSApp.isActive {
// We need to keep track of the windows that were visible because we only
Expand Down