Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Supprimer mailjet #1632

Merged
merged 8 commits into from
Feb 13, 2025
Merged

feat: Supprimer mailjet #1632

merged 8 commits into from
Feb 13, 2025

Conversation

Guilouf
Copy link
Collaborator

@Guilouf Guilouf commented Jan 13, 2025

Quoi ?

Supprimer tout ce qui concerne Mailjet

Pourquoi ?

Mailjet n'est plus utilisé pour envoyer des emails avec template

Comment ?

Attirer l'attention sur les décisions d'architecture ou de conception importantes.

TODO

  • Penser à nettoyer les varenv clevercloud
  • TENDERS_PARTNER_PRESENTATION
  • Dans SiaeSearchResultsDownloadView, plus d'ajout à contact_list ?
  • Siae pas ajouté à la contact list dans leur création depuis emploi inclusion
  • Les emails envoyés par EMAIL_BACKEND sont toujours maijet ?

@Guilouf Guilouf added the enhancement New feature or request label Jan 13, 2025
@Guilouf Guilouf self-assigned this Jan 13, 2025
@Guilouf Guilouf changed the title Supprimer mailjet feat: Supprimer mailjet Jan 13, 2025
@Guilouf Guilouf force-pushed the guilouf/remove-mailjet branch from 763c8d0 to ec53266 Compare January 13, 2025 15:02
@madjid-asa madjid-asa force-pushed the guilouf/remove-mailjet branch from ec53266 to 38f20ad Compare February 4, 2025 19:58
@madjid-asa madjid-asa force-pushed the guilouf/remove-mailjet branch from 38f20ad to 4fc0734 Compare February 4, 2025 21:25
Copy link

gitguardian bot commented Feb 4, 2025

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

lemarche/static/js/favorite_item.js Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_esat_from_asp.py Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_esat_from_asp.py Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_esat_from_csv.py Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_esat_gesat.py Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_esat_handeco.py Dismissed Show dismissed Hide dismissed
lemarche/siaes/management/commands/import_sep.py Dismissed Show dismissed Hide dismissed
lemarche/www/auth/views.py Dismissed Show dismissed Hide dismissed
lemarche/www/siaes/views.py Dismissed Show dismissed Hide dismissed
lemarche/www/siaes/views.py Dismissed Show dismissed Hide dismissed
@madjid-asa madjid-asa force-pushed the guilouf/remove-mailjet branch from 4fc0734 to 588ee61 Compare February 5, 2025 10:08
@Guilouf Guilouf force-pushed the guilouf/remove-mailjet branch from 44b66a7 to 3f430a2 Compare February 7, 2025 09:16
@Guilouf Guilouf force-pushed the guilouf/remove-mailjet branch from db8cbe3 to c82411b Compare February 13, 2025 09:47
@Guilouf Guilouf marked this pull request as ready for review February 13, 2025 09:49
@Guilouf Guilouf force-pushed the guilouf/remove-mailjet branch from c82411b to 44e43d6 Compare February 13, 2025 13:36
Copy link
Contributor

@madjid-asa madjid-asa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Guilouf Guilouf force-pushed the guilouf/remove-mailjet branch from 44e43d6 to 41a64a8 Compare February 13, 2025 18:00
@Guilouf Guilouf merged commit cdc6634 into master Feb 13, 2025
8 checks passed
@Guilouf Guilouf deleted the guilouf/remove-mailjet branch February 13, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants