Add annotation creation access flag #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
reviewed
Aug 17, 2022
| @@ -58,6 +59,10 @@ def validateBoolean(doc): | |||
| constants.PluginSettings.LARGE_IMAGE_ANNOTATION_HISTORY: True, | |||
| }) | |||
|
|
|||
| # Access flags | |||
|
|
|||
| registerAccessFlag('createAnnots', 'Create annotations', 'Allow user to create annotations') | |||
There was a problem hiding this comment.
Can we define this access flag (the createAnnots) in girder/girder_large_image/constants.py (maybe at the root level of that modules as ANNOTATION_ACCESS_FLAG = 'large_image_create_annotations'), and then use the constant instead of the explicit string?
|
Other than preferring a defined constant to a string, this looks good. |
manthey
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new girder access flag which demarcates whether or not a user has permission to create annotations, allowing users to create annotations without having write access to a folder/item. Also creates a new endpoint indicating whether or not the user has creation permissions (via write access or the flag) and makes current annotation creation procedures check for the access flag.