Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now unnecessary patch to fix failing CLI tests #3746

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented Oct 4, 2024

This removes a patch that has become unnecessary as of microsoft/vscode#227427. This does break compatibility with older VS Code versions for tests, but we always run the tests with the newest version of VS Code.

Successful run: https://github.com/github/vscode-codeql/actions/runs/11176227294

@koesie10 koesie10 requested a review from a team as a code owner October 4, 2024 08:17
@koesie10 koesie10 merged commit 473d289 into main Oct 4, 2024
29 checks passed
@koesie10 koesie10 deleted the koesie10/fix-tests branch October 4, 2024 08:38
@koesie10 koesie10 mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants