Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nested preload with join panic when find #6877

Merged
merged 1 commit into from
Mar 9, 2024
Merged

fix: nested preload with join panic when find #6877

merged 1 commit into from
Mar 9, 2024

Conversation

black-06
Copy link
Contributor

@black-06 black-06 commented Mar 6, 2024

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

When query with nested preload and nested join, the preloadEntryPoint ignored the slice type, so it panic.
See and close #6834

User Case Description

DB.Joins("Update.Repo").Joins("Update").Preload("Update.DispatchRecords").Find(&deviceUpdates)

@black-06 black-06 requested a review from a631807682 March 6, 2024 11:18
@jinzhu jinzhu merged commit e4e23d2 into go-gorm:master Mar 9, 2024
35 checks passed
This was referenced Apr 11, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a631807682 a631807682 a631807682 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Joins and Preload Regression with gorm version 1.25.7
3 participants
@black-06 @a631807682 @jinzhu