groot/riofs: align default compression settings w/ ROOT #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groot was using flate.BestCompression (zlib and level=9) whereas ROOT/C++ is using flate.BestSpeed (zlib and level=1). This CL configures groot to use flate.DefaultCompression (and zlib). On "typical" payloads this amounts to: ``` $> time ./new-dbg -zip=zlib-1 -o groot-zlib-1.root real 0m9.469s user 0m8.644s sys 0m0.872s $> time ./new-dbg -zip=zlib-6 -o groot-zlib-6.root real 0m10.832s user 0m10.422s sys 0m0.972s $> time ./new-dbg -zip=zlib-9 -o groot-zlib-9.root ([email protected] default) real 0m32.415s user 0m32.550s sys 0m1.086s ``` and for the disk sizes: ``` $> ll total 510M 87M Nov 12 15:19 groot-zlib-1.root 77M Nov 12 15:18 groot-zlib-6.root 67M Nov 12 15:19 groot-zlib-9.root ([email protected] default) ``` Signed-off-by: Sebastien Binet <[email protected]>
sbinet
force-pushed
the
groot-default-compr-level
branch
from
7d454e2
to
4130003
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
=======================================
Coverage 67.35% 67.35%
=======================================
Files 493 493
Lines 71972 71973 +1
=======================================
+ Hits 48476 48478 +2
Misses 21155 21155
+ Partials 2341 2340 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
groot was using flate.BestCompression (zlib and level=9) whereas ROOT/C++ is using flate.BestSpeed (zlib and level=1).
This CL configures groot to use flate.DefaultCompression (and zlib).
On "typical" payloads this amounts to:
and for the disk sizes: