Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groot/riofs: align default compression settings w/ ROOT #1021

Merged
merged 1 commit into from
Nov 13, 2024

Commits on Nov 13, 2024

  1. groot/riofs: align default compression settings w/ ROOT

    groot was using flate.BestCompression (zlib and level=9) whereas
    ROOT/C++ is using flate.BestSpeed (zlib and level=1).
    
    This CL configures groot to use flate.DefaultCompression (and zlib).
    
    On "typical" payloads this amounts to:
    
    ```
    $> time ./new-dbg -zip=zlib-1 -o groot-zlib-1.root
    real 0m9.469s
    user 0m8.644s
    sys  0m0.872s
    
    $> time ./new-dbg -zip=zlib-6 -o groot-zlib-6.root
    real 0m10.832s
    user 0m10.422s
    sys  0m0.972s
    
    $> time ./new-dbg -zip=zlib-9 -o groot-zlib-9.root ([email protected] default)
    real 0m32.415s
    user 0m32.550s
    sys  0m1.086s
    ```
    
    and for the disk sizes:
    ```
    $> ll
    total 510M
    87M Nov 12 15:19 groot-zlib-1.root
    77M Nov 12 15:18 groot-zlib-6.root
    67M Nov 12 15:19 groot-zlib-9.root ([email protected] default)
    ```
    
    Signed-off-by: Sebastien Binet <[email protected]>
    sbinet committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    4130003 View commit details
    Browse the repository at this point in the history