change wrong path #1043
change wrong path #1043
Conversation
from go build github.com/google/trillian/server/trillian_log_server/ to go build github.com/google/trillian/cmd/trillian_log_server/
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| @@ -27,8 +27,8 @@ echo 'Reset MySQL database' | |||
| yes | ${GOPATH}/src/github.com/google/trillian/scripts/resetdb.sh | |||
|
|
|||
| echo 'Building Trillian log code' | |||
| go build github.com/google/trillian/server/trillian_log_server/ | |||
| go build github.com/google/trillian/server/trillian_log_signer/ | |||
| go build github.com/google/trillian/cmd/trillian_log_server/ | |||
There was a problem hiding this comment.
I agree that this is closer to being right, but the command still won't work because Go tooling has changed a lot over the years. What this now needs is something more like go install github.com/google/trillian/cmd/trillian_log_server@latest (note the @version).
Did you get this to work? Or has it provided value for understanding how to run it? I ask because it feels like the best thing to do is to delete this script as it is so far out of date, and to my knowledge nobody has run it for a long time. On the other hand, if you are sending a PR to update it, then maybe it is useful?! :-)
There was a problem hiding this comment.
yeah I think this script is out of date too, but it did work on my machine with the local filesystem path (such like /home/go/src/github.com/google/trillian/server/trillian_log_server/ )
maybe i was the latest one who wanna deploy this
from go build github.com/google/trillian/server/trillian_log_server/ to go build github.com/google/trillian/cmd/trillian_log_server/
Checklist