Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change wrong path #1043

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

change wrong path #1043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions trillian/integration/demo-script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ echo 'Reset MySQL database'
yes | ${GOPATH}/src/github.com/google/trillian/scripts/resetdb.sh

echo 'Building Trillian log code'
go build github.com/google/trillian/server/trillian_log_server/
go build github.com/google/trillian/server/trillian_log_signer/
go build github.com/google/trillian/cmd/trillian_log_server/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is closer to being right, but the command still won't work because Go tooling has changed a lot over the years. What this now needs is something more like go install github.com/google/trillian/cmd/trillian_log_server@latest (note the @version).

Did you get this to work? Or has it provided value for understanding how to run it? I ask because it feels like the best thing to do is to delete this script as it is so far out of date, and to my knowledge nobody has run it for a long time. On the other hand, if you are sending a PR to update it, then maybe it is useful?! :-)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think this script is out of date too, but it did work on my machine with the local filesystem path (such like /home/go/src/github.com/google/trillian/server/trillian_log_server/ )
maybe i was the latest one who wanna deploy this

go build github.com/google/trillian/cmd/trillian_log_signer/

echo 'Start a Trillian Log server (do in separate terminal)'
./trillian_log_server --rpc_endpoint=localhost:6962 --http_endpoint=localhost:6963 --logtostderr &
Expand Down