Ensure that the Centipede runner writes the failure atomically and only once. #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/694620550
branch
2 times, most recently
from
1665d35
to
fbdfae8
Compare
…ly once. The atomicity is needed because the function `WriteFailureDescription()` may be called from multiple threads: from the main thread, e.g. for a GoogleTest assertion failure, and from the watchdog thread, e.g. for an OOM. The function should write the failure only once because for failures like stack overflow, it gets called twice: the first time for the stack overflow itself, and the second time from the SIGABRT handler handling the abort that follows the detected stack overflow. PiperOrigin-RevId: 695434225
copybara-service
bot
force-pushed
the
cl/694620550
branch
from
fbdfae8
to
f0969ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the Centipede runner writes the failure atomically and only once.
The atomicity is needed because the function
WriteFailureDescription()maybe called from multiple threads: from the main thread, e.g. for a GoogleTest
assertion failure, and from the watchdog thread, e.g. for an OOM.
The function should write the failure only once because for failures like stack
overflow, it gets called twice: the first time for the stack overflow itself,
and the second time from the SIGABRT handler handling the abort that follows the
detected stack overflow.