Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the Centipede runner writes the failure atomically and only once. #1446

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Ensure that the Centipede runner writes the failure atomically and only once. #1446

merged 1 commit into from
Nov 11, 2024

Commits on Nov 11, 2024

  1. Ensure that the Centipede runner writes the failure atomically and on… 

    …ly once.

The atomicity is needed because the function `WriteFailureDescription()` may
be called from multiple threads: from the main thread, e.g. for a GoogleTest
assertion failure, and from the watchdog thread, e.g. for an OOM.

The function should write the failure only once because for failures like stack
overflow, it gets called twice: the first time for the stack overflow itself,
and the second time from the SIGABRT handler handling the abort that follows the
detected stack overflow.

PiperOrigin-RevId: 695434225
    @fniksic @copybara-github
    fniksic authored and copybara-github committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    f0969ce View commit details
    Browse the repository at this point in the history