room-tojson-fails-when-rooom-doesnt-have-owner #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the owner in `Room`'s `toJson` with a null check. This means that `toJson` can be called on a `Room` regardless of if it has an owner or not (since rooms returned by get_all_rooms don't have their owners included in the return), and by adding the `id` field to `User`'s `toJson`, the api remains backwards compatible.
|
Fixes #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added id to the
User'stoJson, and replaced call togetId()for the owner inRoom'stoJsonwith a null check.This means that
toJsoncan be called on aRoomregardless of if it has an owner or not (since rooms returned by get_all_rooms don't have their owners included in the return).By adding the
idfield toUser'stoJson, the api remains backwards compatible, since theidfield remains.