Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

room-tojson-fails-when-rooom-doesnt-have-owner #43

Closed
wants to merge 1 commit into from
Closed

room-tojson-fails-when-rooom-doesnt-have-owner #43

wants to merge 1 commit into from

Commits on May 25, 2017

  1. Added id to the User's toJson, and replaced call to getId() for… 

    … the owner in `Room`'s `toJson` with a null check.

 This means that `toJson` can be called on a `Room` regardless of if it has an owner or not (since rooms returned by get_all_rooms don't have their owners included in the return),
  and by adding the `id` field to `User`'s `toJson`, the api remains backwards compatible.
    @G-Rath
    G-Rath committed May 25, 2017
    Configuration menu
    Copy the full SHA
    48586d6 View commit details
    Browse the repository at this point in the history