fix: repoint Trivy to use ECR mirror

[ramirezj]

see: aquasecurity/trivy-action#389

Summary by CodeRabbit

• New Features

  • Enhanced vulnerability scanning capabilities with new environment variables for Trivy.
  • Improved output handling for SARIF format in the scanning process.

• Bug Fixes

  • Updated permissions for the Trivy job to ensure successful results upload to the code-scanning dashboard.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the GitHub Actions workflow defined in .github/workflows/speculative-plan.yaml. Modifications include the addition of environment variables for the Trivy job, specifically TRIVY_DB_REPOSITORY and TRIVY_JAVA_DB_REPOSITORY, along with a permissions update for security-events: write. The trivy_sarif variable has also been added to specify the output file for SARIF format. The overall structure of the workflow remains unchanged, with existing jobs continuing to function as before.

Changes

File	Change Summary
.github/workflows/speculative-plan.yaml	- Added environment variables: TRIVY_DB_REPOSITORY, TRIVY_JAVA_DB_REPOSITORY in trivy job. - Updated permissions: security-events: write in trivy job. - Updated environment variable: trivy_sarif in trivy job.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

.github/workflows/speculative-plan.yaml (1)

Line range hint 94-94: Missing environment variable definition

The workflow references ${{ env.trivy_sarif }} in the output parameter, but the trivy_sarif variable is not defined in the environment variables section.

Add the missing variable definition:

    env:
+     trivy_sarif: 'trivy-results.sarif'

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5b584e1 and f1c6af0.

📒 Files selected for processing (1)

• .github/workflows/speculative-plan.yaml (1 hunks)

🔇 Additional comments (3)

.github/workflows/speculative-plan.yaml (3)

Line range hint 67-70: Well-structured permissions configuration

The addition of security-events: write permission is appropriate and follows the principle of least privilege, being specifically scoped for uploading scan results to GitHub's code-scanning dashboard.

---

100-102: Appropriate use of ECR mirrors for Trivy databases

The configuration correctly points to public ECR mirrors for both the main Trivy database and Java-specific database, which should improve reliability and potentially reduce rate limiting issues.

---

100-102: Verify ECR mirror configuration

Let's verify if there are any other Trivy-related configurations in the codebase that might need updating for consistency.