-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3793. Simplifies and makes correct KeyDown/Up
API, Fixes: CollectionNavigator
should be called on KeyDown
#3795
Merged
tig
merged 15 commits into
gui-cs:v2_develop
from
tig:v2_3793-CollectionNavigator-Use-OnKeyDown
Oct 15, 2024
Merged
Fixes #3793. Simplifies and makes correct KeyDown/Up
API, Fixes: CollectionNavigator
should be called on KeyDown
#3795
tig
merged 15 commits into
gui-cs:v2_develop
from
tig:v2_3793-CollectionNavigator-Use-OnKeyDown
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tig
changed the title
Fixes #3793.
Fixes #3793. Simplfies and makes correct Oct 14, 2024
CollectionNavigator
should be called on KeyDown
, fixes View.KeyDown/Up
APIView.KeyDown/Up
API CollectionNavigator
should be called on KeyDown
, fixes
tig
changed the title
Fixes #3793. Simplfies and makes correct
Fixes #3793. Simplifies and makes correct Oct 14, 2024
View.KeyDown/Up
API CollectionNavigator
should be called on KeyDown
, fixes KeyDown/Up
API, Fixes: CollectionNavigator
should be called on KeyDown
Added ability to mark/unmark all to ListView
BDisp
approved these changes
Oct 15, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Command
is too tightly coupled withKeyBindings
#3778Proposed Changes/Todos
View.OnKeyDown/Up
to use proper event patterns and simplifyApplication.KeyDown
handlingInvokingKeyBindings
event.ListView
,TableView
, andTreeView
to use correct eventskeyboard.md
, and addevents.md
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)