Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3793. Simplifies and makes correct KeyDown/Up API, Fixes: CollectionNavigator should be called on KeyDown #3795

Merged
merged 15 commits into from
Oct 15, 2024

Conversation

tig
Copy link
Collaborator

@tig tig commented Oct 13, 2024

Fixes

Proposed Changes/Todos

  • Refactor View.OnKeyDown/Up to use proper event patterns and simplify
  • Simplify Application.KeyDown handling
  • Git rid of unused and unneeded InvokingKeyBindings event.
  • Fix ListView, TableView, and TreeView to use correct events
  • Fix associated unit tests
  • Update API docs, fix keyboard.md, and add events.md

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig changed the title Fixes #3793. CollectionNavigator should be called on KeyDown, fixes View.KeyDown/Up API Fixes #3793. Simplfies and makes correct View.KeyDown/Up API CollectionNavigator should be called on KeyDown, fixes Oct 14, 2024
@tig tig changed the title Fixes #3793. Simplfies and makes correct View.KeyDown/Up API CollectionNavigator should be called on KeyDown, fixes Fixes #3793. Simplifies and makes correct KeyDown/Up API, Fixes: CollectionNavigator should be called on KeyDown Oct 14, 2024
Added ability to mark/unmark all to ListView
@tig tig marked this pull request as ready for review October 14, 2024 23:30
@tig tig requested review from BDisp and tznind October 14, 2024 23:30
@tig tig merged commit 23eb14c into gui-cs:v2_develop Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing 'c' in UICatalog does not move to 'Colors' category
2 participants