Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASCWriter speed improvement #1856

Merged
merged 6 commits into from
Sep 13, 2024
Merged

ASCWriter speed improvement #1856

merged 6 commits into from
Sep 13, 2024

Conversation

pierreluctg
Copy link
Collaborator

@pierreluctg pierreluctg commented Sep 12, 2024 •
edited
Loading

Changed how the message data is converted to string.

Main

$ python -m timeit -s "import can; writer=can.ASCWriter('test.asc')" "writer(can.Message(data=range(64)))"
20000 loops, best of 5: 10.8 usec per loop

This PR

$ python -m timeit -s "import can; writer=can.ASCWriter('test.asc')" "writer(can.Message(data=range(64)))"
50000 loops, best of 5: 3.97 usec per loop

@pierreluctg pierreluctg added enhancement file-io about reading & writing to files labels Sep 12, 2024
@pierreluctg pierreluctg marked this pull request as ready for review September 12, 2024 15:57
felixdivo
felixdivo approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

test/logformats_test.py Outdated Show resolved Hide resolved
pierreluctg and others added 6 commits September 13, 2024 10:28
@pierreluctg
ASCWriter speed improvement
67f7018 
Changed how the message data is converted to string. This results in and 100% speed improvement.

On my PC, before the change, logging 10000 messages was taking ~16 seconds and this change drop it to ~8 seconds. With this change, the ASCWriter is still one of the slowest writer we have in Python-can.
@pierreluctg
Update asc.py
203d98e
@pierreluctg
Update logformats_test.py
d83c896
@pierreluctg
Create single_frame.asc
6ecf7cf
@pierreluctg
Update logformats_test.py
4aa6bfa
@pierreluctg @felixdivo
Update test/logformats_test.py
43253a5 
Co-authored-by: Felix Divo <[email protected]>
@pierreluctg pierreluctg merged commit d4f3954 into main Sep 13, 2024
64 checks passed
@pierreluctg pierreluctg deleted the ASCWriter-speed branch September 13, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zariiii9003 zariiii9003 zariiii9003 approved these changes

@felixdivo felixdivo felixdivo approved these changes

@hardbyte hardbyte Awaiting requested review from hardbyte

Assignees
No one assigned
Labels
enhancement file-io about reading & writing to files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierreluctg @felixdivo @zariiii9003