Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASCWriter speed improvement #1856

Merged
merged 6 commits into from
Sep 13, 2024
Merged

ASCWriter speed improvement #1856

merged 6 commits into from
Sep 13, 2024

Commits on Sep 13, 2024

  1. ASCWriter speed improvement 

    Changed how the message data is converted to string. This results in and 100% speed improvement.

On my PC, before the change, logging 10000 messages was taking ~16 seconds and this change drop it to ~8 seconds. With this change, the ASCWriter is still one of the slowest writer we have in Python-can.
    @pierreluctg
    pierreluctg committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    67f7018 View commit details
    Browse the repository at this point in the history

  2. Update asc.py

    @pierreluctg
    pierreluctg committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    203d98e View commit details
    Browse the repository at this point in the history

  3. Update logformats_test.py

    @pierreluctg
    pierreluctg committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d83c896 View commit details
    Browse the repository at this point in the history

  4. Create single_frame.asc

    @pierreluctg
    pierreluctg committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6ecf7cf View commit details
    Browse the repository at this point in the history

  5. Update logformats_test.py

    @pierreluctg
    pierreluctg committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4aa6bfa View commit details
    Browse the repository at this point in the history

  6. Update test/logformats_test.py 

    Co-authored-by: Felix Divo <[email protected]>
    @pierreluctg @felixdivo
    pierreluctg and felixdivo committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    43253a5 View commit details
    Browse the repository at this point in the history