Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP-1056 Block File Reader #10072

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

code smells again

f6940e5
Select commit
Loading
Failed to load commit list.
Open

HIP-1056 Block File Reader #10072

code smells again
f6940e5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 0s

92.20% (-0.02%) compared to c1fa7bc

View this Pull Request on Codecov

92.20% (-0.02%) compared to c1fa7bc

Details

Codecov Report

Attention: Patch coverage is 90.12346% with 16 lines in your changes missing coverage. Please review.

Project coverage is 92.20%. Comparing base (c1fa7bc) to head (f6940e5).

Files with missing lines Patch % Lines
...or/importer/reader/block/ProtoBlockFileReader.java 88.07% 4 Missing and 9 partials ⚠️
...ror/importer/reader/block/BlockRootHashDigest.java 93.61% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #10072      +/-   ##
============================================
- Coverage     92.21%   92.20%   -0.02%     
- Complexity     7858     7897      +39     
============================================
  Files           956      958       +2     
  Lines         32938    33099     +161     
  Branches       4151     4170      +19     
============================================
+ Hits          30373    30518     +145     
- Misses         1588     1595       +7     
- Partials        977      986       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov