chore: upgrade to yarn 4 #2697
chore: upgrade to yarn 4 #2697
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
ui
addons
desktop
admin
api-addon
auth-addon
styles-addon
labels
| @@ -137,21 +137,5 @@ module.exports = { | |||
| }); | |||
| }); | |||
| }, | |||
| packageAfterPrune: async (_, buildPath) => { | |||
There was a problem hiding this comment.
since we are pinning node-gyp v10, we don't need this workaround anymore, I tested it, but lmk if there's anything I missed
|
|
||
| nodeLinker: node-modules | ||
|
|
||
| yarnPath: .yarn/releases/yarn-4.6.0.cjs |
There was a problem hiding this comment.
I agree about not pushing for corepack if it's unlikely to be used with node in the future. Is this method of vendoring yarn preferred over a community github action? Vendoring could be a good approach approach, I'm just wondering how do we would go about updating (and verifying) the vendored file in the future?
There was a problem hiding this comment.
Hmm googling this feedback
There was a problem hiding this comment.
I was thinking of doing manual updates, the local installation says whenever there is a new yarn update and that can be a good indicator to update yarn. Are you thinking of other alternatives that we can use in place of corepack? I did not investigate other options but might be worth considering in the future
|
There's two yarn links in the root |
| "nohoist": [ | ||
| "**/electron**" |
There was a problem hiding this comment.
Are we still planning on no hoisting? I realize now that this probably wasn't even working correctly as I'm not sure that glob was accurate and I think some electron packages moved namespaces to @electron at some point which we never updated
I also don't have context as to why we needed to nohoist them in the first place so I'm guessing we might not even need it
There was a problem hiding this comment.
it does not look like we need to do the equivalent of nohoist in yarn 4, I tested it with and without in both yarn 1 and yarn4 and did not see any issue so my guess is that it is not needed.
Description
Jira This PR upgrades yarn from 1 to 4.
pipeline ✅
PR here
NOTE: This migration is done by committing the binary file instead of using corepack as committing the binary and accessing it via yarnPath seems like the safest/simplest option given the state of corepack support from node.(nodejs/node#51981)
Screenshots (if appropriate)
How to Test
npx npkill -D -x -y[to remove all node_modules]yarn installChecklist
[ ] I have added before and after screenshots for UI changes[ ] I have added JSON response output for API changes[ ] I have added steps to reproduce and test for bug fixes in the description[ ] I have commented on my code, particularly in hard-to-understand areas[ ] My changes generate no new warnings[ ] I have added tests that prove my fix is effective or that my feature works