-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to yarn 4 #2697
base: main
Are you sure you want to change the base?
chore: upgrade to yarn 4 #2697
Changes from all commits
e161110
840683f
9dd9a15
732c689
1612647
a998bdf
249fa39
dd7bd20
147c1a9
8b67287
dc6e541
9ad2699
b8efa81
0dfb977
cc16789
15e92c6
bac7d24
0c3eeab
53b9cfc
5ee79a1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,3 +40,7 @@ yarn-error.log | |
# Ignore all local history of files | ||
.history | ||
.ionide | ||
|
||
#yarn | ||
.yarn/* | ||
!.yarn/releases |
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# Copyright (c) HashiCorp, Inc. | ||
# SPDX-License-Identifier: BUSL-1.1 | ||
|
||
nodeLinker: node-modules | ||
|
||
yarnPath: .yarn/releases/yarn-4.6.0.cjs | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,39 +8,37 @@ | |
"addons/*", | ||
"ui/*", | ||
"e2e-tests" | ||
], | ||
"nohoist": [ | ||
"**/electron**" | ||
Comment on lines
-12
to
-13
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we still planning on no hoisting? I realize now that this probably wasn't even working correctly as I'm not sure that glob was accurate and I think some electron packages moved namespaces to I also don't have context as to why we needed to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it does not look like we need to do the equivalent of |
||
] | ||
}, | ||
"scripts": { | ||
"build": "yarn build:ui:admin", | ||
"build:ui:admin": "yarn --cwd ui/admin build", | ||
"build:ui:admin:oss": "yarn --cwd ui/admin build:oss", | ||
"build:ui:admin:enterprise": "yarn --cwd ui/admin build:enterprise", | ||
"build:ui:admin:hcp": "yarn --cwd ui/admin build:hcp", | ||
"build:ui:desktop": "yarn --cwd ui/desktop build", | ||
"build:ui:desktop:production": "yarn --cwd ui/desktop build:production", | ||
"build:ui:desktop:app": "yarn --cwd ui/desktop build:desktop", | ||
"build:ui:admin": "yarn workspace admin build", | ||
DhariniJeeva marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"build:ui:admin:oss": "yarn workspace admin build:oss", | ||
"build:ui:admin:enterprise": "yarn workspace admin build:enterprise", | ||
"build:ui:admin:hcp": "yarn workspace admin build:hcp", | ||
"build:ui:desktop": "yarn workspace desktop build", | ||
"build:ui:desktop:production": "yarn workspace desktop build:production", | ||
"build:ui:desktop:app": "yarn workspace desktop build:desktop", | ||
"lint": "concurrently \"yarn:lint:*\" --names \"lint:\"", | ||
"lint:addons-api": "yarn --cwd addons/api lint", | ||
"lint:addons-auth": "yarn --cwd addons/auth lint", | ||
"lint:addons-core": "yarn --cwd addons/core lint", | ||
"lint:addons-rose": "yarn --cwd addons/rose lint", | ||
"lint:ui-admin": "yarn --cwd ui/admin lint", | ||
"lint:ui-desktop": "yarn --cwd ui/desktop lint", | ||
"lint:addons-api": "yarn workspace api lint", | ||
"lint:addons-auth": "yarn workspace auth lint", | ||
"lint:addons-core": "yarn workspace core lint", | ||
"lint:addons-rose": "yarn workspace rose lint", | ||
"lint:ui-admin": "yarn workspace admin lint", | ||
"lint:ui-desktop": "yarn workspace desktop lint", | ||
"test": "concurrently \"yarn:test:*\" --names \"test:\"", | ||
"test:addons-api": "yarn --cwd addons/api test", | ||
"test:addons-auth": "yarn --cwd addons/auth test", | ||
"test:addons-core": "yarn --cwd addons/core test", | ||
"test:addons-rose": "yarn --cwd addons/rose test", | ||
"test:ui-admin": "yarn --cwd ui/admin test", | ||
"test:ui-desktop": "yarn --cwd ui/desktop test", | ||
"compliance:licenses": "license-checker --onlyAllow 'Apache*;Apache License, Version 2.0;Apache-2.0;Apache 2.0;Artistic-2.0;BSD;BSD-3-Clause;CC-BY-3.0;CC-BY-4.0;CC0-1.0;ISC;MIT;MPL-2.0;BUSL-1.1;Public Domain;Python-2.0;Unicode-TOU;Unlicense;WTFPL' --excludePackages 'boundary-ui;[email protected];[email protected];[email protected];[email protected];[email protected];[email protected];@hashicorp/[email protected];[email protected]'", | ||
"test:addons-api": "yarn workspace api test", | ||
"test:addons-auth": "yarn workspace auth test", | ||
"test:addons-core": "yarn workspace core test", | ||
"test:addons-rose": "yarn workspace rose test", | ||
"test:ui-admin": "yarn workspace admin test", | ||
"test:ui-desktop": "yarn workspace desktop test", | ||
"compliance:licenses": "license-checker --onlyAllow 'Apache*;Apache License, Version 2.0;Apache-2.0;Apache 2.0;Artistic-2.0;BSD;BSD-3-Clause;CC-BY-3.0;CC-BY-4.0;CC0-1.0;ISC;MIT;MPL-2.0;BUSL-1.1;Public Domain;Python-2.0;Unicode-TOU;Unlicense;WTFPL;BlueOak-1.0.0' --excludePackages 'boundary-ui;[email protected];[email protected];[email protected];[email protected];[email protected];[email protected];@hashicorp/[email protected];[email protected]'", | ||
"doc:toc": "doctoc README.md", | ||
"prepare": "husky" | ||
}, | ||
"devDependencies": { | ||
"concurrently": "^9.1.0", | ||
DhariniJeeva marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"cz-conventional-changelog": "^3.3.0", | ||
"doctoc": "^2.2.0", | ||
"git-cz": "^4.9.0", | ||
|
@@ -49,20 +47,20 @@ | |
"lint-staged": "^15.2.10" | ||
}, | ||
"resolutions": { | ||
"**/nomnom/underscore": "^1.12.1", | ||
"**/core/ember-inline-svg/**/nth-check": "^2.0.1", | ||
"**/ember-cli/**/ansi-html": "^0.0.9", | ||
"**/ember-cli/testem/fireworm/async": "^2.6.4", | ||
"**/@hashicorp/design-system-components/ember-stargate": "^0.6.0", | ||
"micromatch": "^4.0.8" | ||
"nomnom/underscore": "^1.12.1", | ||
DhariniJeeva marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"@hashicorp/design-system-components/ember-stargate": "^0.6.0", | ||
"micromatch": "^4.0.8", | ||
"ember-inline-svg/nth-check": "^2.0.1", | ||
"node-gyp": "^10.0.0", | ||
"ember-cli/ansi-html": "^0.0.9", | ||
"fireworm/async": "^2.6.4" | ||
}, | ||
"config": { | ||
"commitizen": { | ||
"path": "./node_modules/cz-conventional-changelog" | ||
"path": "git-cz" | ||
} | ||
}, | ||
"engines": { | ||
"node": "20.* || 22.*" | ||
}, | ||
"packageManager": "[email protected]+sha1.4ba7fc5c6e704fce2066ecbfb0b0d8976fe62447" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,3 +33,6 @@ | |
|
||
# broccoli-debug | ||
/DEBUG/ | ||
|
||
#yarn | ||
.yarn/* |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -100,3 +100,6 @@ ember-test/ | |
|
||
# Autoupdate | ||
nextVersion/ | ||
|
||
#yarn | ||
.yarn/* |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -137,21 +137,5 @@ module.exports = { | |
}); | ||
}); | ||
}, | ||
packageAfterPrune: async (_, buildPath) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since we are pinning node-gyp v10, we don't need this workaround anymore, I tested it, but lmk if there's anything I missed |
||
// This is needed to delete temporary sym links when creating an asar during | ||
// building for native node modules. | ||
|
||
// TODO: This issue was fixed and merged in a recent PR as noted here | ||
// https://github.com/nodejs/node-gyp/issues/2713 so we should update node-gyp | ||
// when it gets released and remove this workaround | ||
const gypPath = path.join( | ||
buildPath, | ||
'node_modules', | ||
'node-pty', | ||
'build', | ||
'node_gyp_bins', | ||
); | ||
await fs.promises.rm(gypPath, { recursive: true, force: true }); | ||
}, | ||
}, | ||
}; |
DhariniJeeva marked this conversation as resolved.
Show resolved
Hide resolved
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree about not pushing for corepack if it's unlikely to be used with node in the future. Is this method of vendoring yarn preferred over a community github action? Vendoring could be a good approach approach, I'm just wondering how do we would go about updating (and verifying) the vendored file in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm googling this feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of doing manual updates, the local installation says whenever there is a new yarn update and that can be a good indicator to update yarn. Are you thinking of other alternatives that we can use in place of corepack? I did not investigate other options but might be worth considering in the future