Add GHC 9.6 CI to the 3.10 branch #8901

Kleidukos · 2023-04-06T18:17:26Z

Backport of #8840 for the 3.10 branch

ulysses4ever · 2023-04-06T18:21:56Z

.github/workflows/validate.yml

+            dist-*
+          key: ${{ runner.os }}-${{ matrix.ghc }}-${{ github.sha }}
+          restore-keys: ${{ runner.os }}-${{ matrix.ghc }}-
+
      - uses: haskell/actions/setup@v2
        id: setup-haskell
        with:
          ghc-version: ${{ matrix.ghc }}
          cabal-version: '3.8.1.0'


Let's see what CI says. I'm curious if it will twist our hand to bump the cabal version here or not.

well-spotted, 3.8 has TypeInType

(My bad, i always rush to hit Comment...) My worry was specifically about the test suite : it's very peculiar about the version of cabal-install you're compiling it with. It now fails with 3.10. You probably will have to try to revert to 3.8 and see if that works...

ulysses4ever · 2023-04-07T13:52:01Z

cabal-testsuite/cabal-testsuite.cabal

-    , Cabal ^>= 3.10.0.0
-    , Cabal-syntax ^>= 3.10.0.0
+    , Cabal ^>= 3.10
+    , Cabal-syntax ^>= 3.10


I thought this will make no difference. But it's fine this way, i guess.

ulysses4ever · 2023-04-07T13:53:35Z

cabal-testsuite/cabal-testsuite.cabal

@@ -115,6 +115,6 @@ custom-setup
  -- and due to Custom complexity and ConstraintSetupCabalMaxVersion
  -- it has to be the latest release version plus
  -- you have to use the latest cabal-install release
-  setup-depends: Cabal == 3.8.*,
-                 Cabal-syntax == 3.8.*,
+  setup-depends: Cabal == 3.10.*,


Now this is smart! I could not guess such a solution.

May this be related the CI old GHCs failure we are seeing right now?

Yeah, a priori I thought that this would stay as is was, and the cabal-install in the CI would stay 3.8 also. But I must say I have no explanation for this. It's just a hunch.

Kleidukos · 2023-04-07T16:36:32Z

Blocked by ulysses4ever/rere#20

ulysses4ever · 2023-04-07T18:26:14Z

@Kleidukos there's no ETA for it, so i suggest using allow-newer. That's what I did on master.

ulysses4ever · 2023-04-08T17:25:40Z

validate.sh

@@ -13,7 +13,7 @@
 HC=ghc
 CABAL=cabal
 CABALPLAN=cabal-plan
-JOBS=4
+JOBS=12


This is bold! You realize that it won't affect the CI, right? 'Cause validate.yml sets its own -j and passes it to this script.

ergh, yeah it's a remnant from my local development. :)

ulysses4ever · 2023-04-11T23:49:06Z

rere was updated for the latest base btw

Mikolaj · 2023-04-19T20:50:31Z

cabal-testsuite/cabal-testsuite.cabal

@@ -115,6 +115,6 @@ custom-setup
  -- and due to Custom complexity and ConstraintSetupCabalMaxVersion
  -- it has to be the latest release version plus
  -- you have to use the latest cabal-install release
-  setup-depends: Cabal == 3.8.*,
-                 Cabal-syntax == 3.8.*,
+  setup-depends: Cabal ^>= 3.10,


So, shall we try reverting this to 3.8? This is completely dark art and only affects custom setup tests, so whatever works IMHO.

Kleidukos · 2023-04-20T17:45:24Z

I'll use GHC 9.6 for the "old GHC" jobs instead of 8.8

Backport of haskell#8840

Kleidukos · 2023-04-20T20:14:33Z

Error: Unable to locate executable file: sudo. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executa

ah. okay.

Kleidukos · 2023-04-22T19:12:40Z

E: Unable to locate package ghc-7.10.3-dyn
E: Couldn't find any package by glob 'ghc-7.10.3-dyn'
E: Couldn't find any package by regex 'ghc-7.10.3-dyn'

Kleidukos · 2023-05-07T13:29:40Z

.github/workflows/validate.yml

# This job needs an older ubuntu (16.04) cause # the required old ghcs using the `-dyn` flavour # are not installable from ppa/hvr in newer ones # see https://github.com/haskell/cabal/issues/8011 container: image: phadej/ghc:8.8.4-xenial

@phadej I'm not sure I see a corresponding image in your dockerhub profile for 9.6.1-xenial. What can we do to remedy to this? Also, are you still willing to maintain such images?

IIRC, there will be no new images.

I don't think there needs to be new images to achieve what it's supposed to achieve. Also, I don't think this part of the code should have been touched as a part of the backport.

Feel free to toy with it, I'm out of ideas personally :/

Kleidukos requested review from ulysses4ever and Mikolaj and removed request for ulysses4ever April 6, 2023 18:17

ulysses4ever reviewed Apr 6, 2023

View reviewed changes

ulysses4ever approved these changes Apr 6, 2023

View reviewed changes

Kleidukos changed the title ~~Add GHC 9.6 CI~~ Add GHC 9.6 CI to the 3.10 branch Apr 7, 2023

ulysses4ever reviewed Apr 7, 2023

View reviewed changes

ulysses4ever reviewed Apr 8, 2023

View reviewed changes

ulysses4ever mentioned this pull request Apr 18, 2023

CI: add GHC 9.6.1 (backport #8840) #8899

Closed

Mikolaj reviewed Apr 19, 2023

View reviewed changes

Kleidukos added 7 commits April 20, 2023 20:37

Add GHC 9.6 CI

2f9358d

Backport of haskell#8840

Use 3.10 for the setup

a9ab7b4

Forgot those ranges

c0846cf

Allow for newer rere dependencies

b955fed

Revert number of jobs

9c0796e

Unify version range syntaxes

76e86d9

Try and use GHC 9.6 instead of 8.8 for old GHCs

bd024c9

Kleidukos force-pushed the use-ghc-9.6-in-ci branch from 9be4627 to bd024c9 Compare April 20, 2023 18:37

sudo is not available in the xenial container

fef89e8

Kleidukos force-pushed the use-ghc-9.6-in-ci branch from 91923cf to fef89e8 Compare April 21, 2023 12:05

uncomment xenial container

834bf18

Kleidukos force-pushed the use-ghc-9.6-in-ci branch from a377b02 to 834bf18 Compare May 7, 2023 13:27

Kleidukos commented May 7, 2023

View reviewed changes

Kleidukos mentioned this pull request May 22, 2023

allow building cabal-install-3.10 with ghc-9.6 #8964

Merged

Kleidukos closed this Jul 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GHC 9.6 CI to the 3.10 branch #8901

Add GHC 9.6 CI to the 3.10 branch #8901

Kleidukos commented Apr 6, 2023 •

edited

Loading

ulysses4ever Apr 6, 2023

Kleidukos Apr 6, 2023

ulysses4ever Apr 6, 2023

ulysses4ever Apr 7, 2023

ulysses4ever Apr 7, 2023

Mikolaj Apr 11, 2023

ulysses4ever Apr 11, 2023

Kleidukos commented Apr 7, 2023

ulysses4ever commented Apr 7, 2023

ulysses4ever Apr 8, 2023

Kleidukos Apr 8, 2023

ulysses4ever commented Apr 11, 2023

Mikolaj Apr 19, 2023

Kleidukos commented Apr 20, 2023

Kleidukos commented Apr 20, 2023

Kleidukos commented Apr 22, 2023

Kleidukos May 7, 2023 •

edited

Loading

Mikolaj May 8, 2023

ulysses4ever May 22, 2023 •

edited

Loading

Kleidukos May 22, 2023

Add GHC 9.6 CI to the 3.10 branch #8901

Add GHC 9.6 CI to the 3.10 branch #8901

Conversation

Kleidukos commented Apr 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kleidukos commented Apr 7, 2023

ulysses4ever commented Apr 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ulysses4ever commented Apr 11, 2023

Choose a reason for hiding this comment

Kleidukos commented Apr 20, 2023

Kleidukos commented Apr 20, 2023

Kleidukos commented Apr 22, 2023

Kleidukos May 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ulysses4ever May 22, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kleidukos commented Apr 6, 2023 •

edited

Loading

Kleidukos May 7, 2023 •

edited

Loading

ulysses4ever May 22, 2023 •

edited

Loading