Enhancements #498
Merged
Enhancements #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
carlhiggs
commented
Jan 9, 2025
carlhiggs
commented
- Updated GHSCI software environment dependencies (software version is now 4.7.0)
- moved towards Migrate to use OSMnx 2.0 #495 (updated OSMnx to 1.9.4)
- addressed Run analysis and resource generation as asynchronous (background) tasks in GHSCI web app #496 improving web app user experience.
- added improved feedback for users on identifying and correcting invalid YAML, and CI test to detect both valid and invalid YAML as per Improved YAML debugging #497
… and ensuring code works under that version
…y no longer be required with newer main packages; trialling broad update of dependencies
…ssfully, but have not yet tested how the code runs
…hemy to apache arrow dbapi right now; can do without that complexity), and added in UseExceptions() call to avoid FutureWarning for ogr and gdal python calls. Also simplified an fstring in gui.py that contained double backslash; caused issues with pre-commit for some reason, so changed the way I am doing it.
…n't retain true name of index due to reversion of geopandas to earlier version per v1.0. The modified code should be robust for when we update to newer version.
…logic after fix #493, checking for 'Government' instead of 'government' with result that example levels of government were left blank; this is now corrected)
… and generating policy report now run in background successfully; however, related to updating to newer nicegui version as part of general software patch updates, the web map indicator popups are not yet functional and more code requires updating). Also reformatted gui.py and local_file_picker.py to pass some of the pre-commit style checks.
… advising of the line number and column the error occurred at and provides users with some guidance on how to deal with it, including a link to the wiki entry for configuration); also added yamllint to dockerfile and am currently rebuilding the 4.7.0 docker image to test its inclusion (along with some other docker scout-related patches)
…gboeing and @eugenrb --- now when the error occurs, yamllint is run in 'relaxed' mode and that error prints first; this is followed by a friendly and formatted message advising users about the likely location of the error (in an easier to read lay way) and where to go for more help. Hopefully this is an improvement.
…on' as a possible cause of error
…r supplied example configuration file matches requirements as per #497
…ml test passing can be trusted (lack of an error when reading valid YAML only counts if we know an error will be raised when reading invalid YAML, so this double checks things for extra configdence); for #497
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.