-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Click-to-Pregrasp #52
Conversation
…ne with generators and only switching modes once
@hello-cpaxton This is ready for a review of the functionality ( |
nodes/move_to_pregrasp.py
Outdated
if not horizontal_grasp: | ||
# For vertical grasp, the goal orientation is also rotated +90deg around y | ||
rot = quaternion_multiply(rot, quaternion_about_axis(np.pi / 2, [0, 1, 0])) | ||
goal_pose_base.pose.orientation = Quaternion( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can probably tweak the formatting rules so this isnt 3 lines
@hello-amal jFYI, I tried running this branch and saw the following errors. You may need to add the |
Thanks for surfacing that @hello-binit . I was able to recreate it when rebuilding from scratch, and the latest commit should address it -- try it out when you get a chance. |
Thanks for the comments @hello-cpaxton ! I addressed them and cleaned up th code. @hello-vinitha , you can review it now when you get a chance. This has been thoroughly tested on the Stretch 3 (with the dex wrist and with the tablet), not yet on earlier configurations. |
@hello-amal I tested this PR on a Stretch 2 with the upgraded teleop kit and dex wrist. The arm collides with the base when the (horizontal) pre-grasp z position is below the base. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on the various Stretch 2 configurations. All tests pass!
Description
This PR implements a feature where the user is able to click a point on the Realsense stream, and if the point is within the robot's reach, it will align with the point with either a horizontal or vertical gripper (user-specified). The aim of this feature is to prevent the iterative and time-consuming movements required for an operator to properly align the gripper with an object to grasp it.
Upgrade Info
See README.md for information on installing the additional requirements and generating the specialized URDF.
Testing procedure
Before opening a pull request
From the top-level of this repository, run:
pre-commit run --all-files
To merge
Squash & Merge