This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
fix test suite for Docker BuildKit #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidpr
changed the title
lucaudill
reviewed
Aug 24, 2023
|
|
||
| # Copy in the new directory tree. In all of these cases, the source simply | ||
| # overwrites the destination; symlinks are not followed. | ||
| # NOTE: Not currently tested (see #1707). |
There was a problem hiding this comment.
You might want to add some extra context for this comment chunk, particularly the commented out Dockerfile instruction that's still included.
| @@ -590,6 +591,10 @@ EOF | |||
| fi | |||
| prerequisites_ok argenv | |||
|
|
|||
| sed_ () { | |||
There was a problem hiding this comment.
I think explaining this function in a comment would be good since the regex is a bit intimidating.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of version 23, Docker’s legacy builder is deprecated and BuildKit is the default. This breaks a number of assumptions in the test suite, both functional and cosmetic. In recent weeks, the updated Docker has appeared in the GitHub Actions image.
This PR updates the test suite to pass again under Docker.