Update Docker Documentation #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adaickalavan
approved these changes
Jan 26, 2021
JingfeiPeng
reviewed
Jan 26, 2021
JingfeiPeng
approved these changes
Jan 26, 2021
JingfeiPeng
reviewed
Jan 26, 2021
| # <press enter> | ||
|
|
||
| # Run Envision server in the background | ||
| # This will only need to be run if you want visualisation | ||
| $ scl envision start -s ./scenarios -p 8081 & |
There was a problem hiding this comment.
do we need the & at the end?
There was a problem hiding this comment.
In this case, yes.
Apply Adai's suggestions. Co-authored-by: adai <[email protected]>
Gamenot
force-pushed
the
hotfix-update_docker_documentation
branch
from
44d04dc to
20dc8d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some missing steps and clarify some existing steps for getting an example running.
This was brought up by someone attempting to use a docker image.
#472