refactor check_tbl_col_ascending #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will address #189
zkamvar
changed the title
While I was looking at this for refactoring, I found that I had re-invented the function to sort the table by output type ID and the task IDs: `match_tbl_to_model_task()`. Happily, this speeds up the process quite a bit _and_ allows me to delete code!
zkamvar
changed the title
zkamvar
changed the title
…t to check_tbl_value_col_ascending
|
Thanks for implementing this so quickly! Instead of a review, as there were quite a few changes I wanted to propose, I went ahed and made a PR instead here: #191 |
Ak/check derived task ids/189
As explained in #191 (comment), > match_tbl_to_model_task() outputs a list element per model task, > not output type. In hindsight, this makes sense, but the original variable name of `output_type_tbls` made me think that each list element was an output type (see #191 (comment)). Changing the `output_type_tbls` variable name to `model_task_tbls` reduces the cognitive load because now I understand that each element represents a model task (which is NULL if the output type does not exist for the model task), and in this function, there is only ever one output type.
annakrystalli
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #105, I had implemented a sorting method for the
check_tbl_col_ascending()function that involved using an expanded model grid subset to thecdfandquantileoutput types to sort the submission table. As pointed out by @annakrystalli, there were two problems:derived_task_idsto the functionbind_model_tasks = TRUEWhile I was looking at this for refactoring, I found that I had re-invented the function to sort the table by output type ID and the task IDs:
match_tbl_to_model_task().Happily, this speeds up the process quite a bit and allows me to delete code!
This will fix #189
EDIT: huge thanks to @annakrystalli for implementing the correct solution and better tests for derived task IDs