-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ak/check derived task ids/189 #191
Ak/check derived task ids/189 #191
Conversation
…t to check_tbl_value_col_ascending
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvements, Anna! It all looks good with two things that can be tweaked:
- the value column still needs to be converted to numeric
- replacing a map over a single-element list with calling the function directly (see comment)
Additionally, should the function signature for check_tbl_value_col_ascending()
be tbl_chr
instead of tbl
so that it's clear it expects a character-only tbl?
This is a good idea but should be applied throughout on all functions that require |
As explained in #191 (comment), > match_tbl_to_model_task() outputs a list element per model task, > not output type. In hindsight, this makes sense, but the original variable name of `output_type_tbls` made me think that each list element was an output type (see #191 (comment)). Changing the `output_type_tbls` variable name to `model_task_tbls` reduces the cognitive load because now I understand that each element represents a model task (which is NULL if the output type does not exist for the model task), and in this function, there is only ever one output type.
Instead of reviewing I've just gone ahead and made a PR with my suggestions.
This PR build on #190 but introduces the following changes:
tbl
and converts just the value column to numeric. This is how the original test was setup and the conversion ofvalue
to numeric was already happening incheck_values_ascending()
on the subset of relevant rows for the check.validate_model_data()
to be thetbl_chr
version of the data. This exists in the function environment as a number of checks depend on the all character version of the model output data.hubValidations
namespace specificationsI've tested locally and all tests pass but will be good to run the tests in your PR once merged in before merging into
main