Allow ModalDialogs with variant='custom' #1442
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of hypothesis/client#6151 and hypothesis/client#6158
Some time ago we added support for
variant="custom"
inDialog
s, which makes it render providedchildren
verbatim, instead of wrapped in aPanel
.However, that capability was not added to
ModalDialog
, so this PR brings that to make it consistent.It is also required so that we can use
ModalDialog
for the client's notebook, bringing some accessibility improvements in the process.