Add creators of new groups as owners #9032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanh
commented
Oct 18, 2024
Comment on lines
+129
to
+131
| self.db.add( | ||
| GroupMembership(user_id=creator.id, group_id=group.id, roles=["owner"]) | ||
| ) |
There was a problem hiding this comment.
I don't know if there's any way to pass through the roles=["owners"] when appending the membership via the group.members relationship? So constructing the GroupMembership object directly instead.
There was a problem hiding this comment.
To be honest I prefer this style. I much more clear what's going on.
seanh
force-pushed
the
add-creators-as-owners
branch
from
0005e13
to
3f9bf26
Compare
marcospri
approved these changes
Oct 22, 2024
seanh
force-pushed
the
add-creators-as-owners
branch
from
3f9bf26
to
ad26ced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9029.