Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abstract class for dialogue policy #238

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

WerLaj
Copy link
Collaborator

@WerLaj WerLaj commented Aug 2, 2023

Fixes #156

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Unit Test Results

81 tests   81 ✔️  1m 13s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 8b0c1f3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Coverage Report •
FileStmtsMissCoverMissing
dialoguekit/core
   dialogue_policy.py10100%16–48
TOTAL202718689% 

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Current Branch Main Branch
Coverage Badge Coverage Badge

@WerLaj WerLaj requested review from kbalog and NoB0 August 2, 2023 15:08
dialoguekit/core/dialogue_policy.py Outdated Show resolved Hide resolved
dialoguekit/core/dialogue_policy.py Outdated Show resolved Hide resolved
dialoguekit/core/dialogue_policy.py Show resolved Hide resolved
dialoguekit/core/dialogue_policy.py Show resolved Hide resolved
dialoguekit/core/dialogue_policy.py Outdated Show resolved Hide resolved
@WerLaj WerLaj requested a review from NoB0 August 3, 2023 09:22
Copy link
Collaborator

@NoB0 NoB0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment on lines +3 to +8
The dialogue policy generates the next dialogue act of an agent based on the
current dialogue state (last user's utterance and dialogue history). It defines
the flow of the conversation, i.e., what steps an agent must take at every
stage. The annotations of the dialogue act represent what the agent must elicit,
recommend, or inform. The output of the dialogue policy is converted to a
natural language response by the natural language generator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NoB0 Is this policy meant only for the conversational agent or could it also be used for a user simulator? In the latter case, this text needs to be updated.

Comment on lines +10 to +13
For example, in the context of recommendation system, the dialogue act with
intent ELICIT is generated if the agent does not store any user preferences.
For the user intent REVEAL, the dialogue policy triggers the generation of an
item recommendation (dialogue act with intent RECOMMEND).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed.

Comment on lines +34 to +36
This method is most likely used in receive_utterance() in the agent to
generate the agent's response. Dialogue act prediction is composed of
two steps: intent prediction and annotation prediction.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed (we don't need to make assumptions about how the agent is implemented).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dialogue Policy
3 participants