-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add abstract class for dialogue policy #238
Open
WerLaj
wants to merge
3
commits into
main
Choose a base branch
from
feature/156-Add-abstract-class-for-dialogue-policy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
"""Abstract interface for dialogue policy. | ||
|
||
The dialogue policy generates the next dialogue act of an agent based on the | ||
current dialogue state (last user's utterance and dialogue history). It defines | ||
the flow of the conversation, i.e., what steps an agent must take at every | ||
stage. The annotations of the dialogue act represent what the agent must elicit, | ||
recommend, or inform. The output of the dialogue policy is converted to a | ||
natural language response by the natural language generator. | ||
|
||
For example, in the context of recommendation system, the dialogue act with | ||
intent ELICIT is generated if the agent does not store any user preferences. | ||
For the user intent REVEAL, the dialogue policy triggers the generation of an | ||
item recommendation (dialogue act with intent RECOMMEND). | ||
Comment on lines
+10
to
+13
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not needed. |
||
""" | ||
|
||
from abc import ABC, abstractmethod | ||
|
||
from dialoguekit.core.dialogue import Dialogue | ||
from dialoguekit.core.dialogue_act import DialogueAct | ||
from dialoguekit.core.utterance import Utterance | ||
|
||
|
||
class DialoguePolicy(ABC): | ||
def __init__(self) -> None: | ||
"""Initializes the dialogue policy.""" | ||
WerLaj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
pass | ||
|
||
@abstractmethod | ||
def next_dialogue_act( | ||
self, user_utterance: Utterance, dialogue_history: Dialogue | ||
) -> DialogueAct: | ||
"""Returns the next dialogue act given the user utterance and history. | ||
|
||
This method is most likely used in receive_utterance() in the agent to | ||
generate the agent's response. Dialogue act prediction is composed of | ||
two steps: intent prediction and annotation prediction. | ||
Comment on lines
+34
to
+36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not needed (we don't need to make assumptions about how the agent is implemented). |
||
|
||
Args: | ||
user_utterance: The last user utterance. | ||
dialogue_history: The dialogue history. | ||
|
||
Raises: | ||
NotImplementedError: If not implemented in derived class. | ||
|
||
Returns: | ||
The next dialogue act. | ||
""" | ||
WerLaj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
raise NotImplementedError |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NoB0 Is this policy meant only for the conversational agent or could it also be used for a user simulator? In the latter case, this text needs to be updated.