Fix CI tests #482
Merged
Fix CI tests #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ardhat in smart_contract_tests to remove previous node version restrictions because of (now fixed) hardhat bug
There was a problem hiding this comment.
I think we should add some information about the current supported node.js versions. Currently, the info is: "First off, make sure you have a recent version of Node.js installed. While any version after v12 should work fine, we recommend you install v16 or later." However, it's important to explicitly specify that versions older than v16 are not guaranteed to work.
Maybe:
"Ensure you have a recent version of Node.js installed. Any version from v16 functions properly. Versions prior to v16 are not guaranteed to work."
|
@xavi-pinsach Thanks! I've added note that non-LTS versions are not guaranteed to work too. Does it sound right to you now? |
xavi-pinsach
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on: [push, pull_request])