Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update various github actions and node versions #2251

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

koddsson
Copy link
Contributor

What I did

  1. I updated some old node versions in CI (node 16 is no longer supported)
  2. I updated some github actions
  3. I changed some npm commands from npm install --ci to npm ci

Copy link

changeset-bot bot commented Apr 14, 2024

⚠️ No Changeset found

Latest commit: e15c5d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@koddsson
Copy link
Contributor Author

I.. did not expect this many errors.

@koddsson koddsson marked this pull request as draft April 14, 2024 20:17
@koddsson koddsson marked this pull request as ready for review April 15, 2024 07:26
@koddsson
Copy link
Contributor Author

An admin is going to need to update the required PR builds so that node 18 is required and not 16 if we are going to merge this.

@gerjanvangeest gerjanvangeest merged commit 3ce4929 into ing-bank:master Apr 16, 2024
5 checks passed
@koddsson koddsson deleted the update-actions branch April 16, 2024 16:21
okadurin added a commit that referenced this pull request Apr 18, 2024
okadurin added a commit that referenced this pull request Apr 18, 2024
Revert "Update various github actions and node versions (#2251)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants