Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2350: Generate survey files async #2362

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

#2350: Generate survey files async #2362

wants to merge 33 commits into from

Conversation

anaPerezGhiglia
Copy link
Contributor

Changes

  • create new SurveyResults GenServer
  • move responsibility of generating files from RespondentController to new SurveyResults actor
  • change files endpoints to "common" POST (without csv format)
  • change UI to make the POST call instead of a redirect to a new location

Out of scope

  • Keep track of generated files in the db
  • Files cleanup policy
  • Download existing files

for #2350

anaPerezGhiglia and others added 17 commits August 13, 2024 12:39
@anaPerezGhiglia @matiasgarciaisaia
create SurveyFilesManager actor to handle generation of files
86648c7
@anaPerezGhiglia @matiasgarciaisaia
Generate interactions file into a new dir
610b742
@anaPerezGhiglia @matiasgarciaisaia
add basic decision for generating file or not
2a05f87
@anaPerezGhiglia @matiasgarciaisaia
Add incentives file to SurveyFilesManager
383a4c3
@anaPerezGhiglia @matiasgarciaisaia
add disposition_history files to SurveyFilesManager
55dd067
@anaPerezGhiglia @matiasgarciaisaia
Convert csv trigger request into POST requests with no csv format
d07a31c
@anaPerezGhiglia @matiasgarciaisaia
add respondents_result file to SurveyFilesManager
074e3f0
@anaPerezGhiglia @matiasgarciaisaia
Cleanup
e7932f0
@anaPerezGhiglia @matiasgarciaisaia
Fix router path to point to new get_respondents_result path
ee47361
@anaPerezGhiglia @matiasgarciaisaia
Remove respondents_where from Survey model
d303147
@anaPerezGhiglia @matiasgarciaisaia
Rename Ask.Runtime.SurveyFilesManager to Ask.SurveyResults
5ff4cee
@anaPerezGhiglia @matiasgarciaisaia
Move all_questionnaires_fields to SurveyResults
adea7e4 
instead of Questionnaire
@anaPerezGhiglia @matiasgarciaisaia
remove unused import
931a236
@matiasgarciaisaia
Scaffold Survey Results tests
4027e03 
See #2350
@matiasgarciaisaia
More tests
e16a77b
@matiasgarciaisaia
Keep moving tests
0e900c4 
See #2350
@matiasgarciaisaia
Make test suite "pass" by skipping broken tests
02a9384 
We should un-skip them by the end of the PR.

See #2350
@matiasgarciaisaia
File downloads UI - first take
ed988f8 
The info about the generated files is still pending.

See #2350
@matiasgarciaisaia
Stub downloading previously generated result files
607b382 
See #2350
@matiasgarciaisaia
Typo
b72c41a 
See #2350
@matiasgarciaisaia
Generate async files in a stable path
b130c76 
This will allow us to check if there already is a file generated or not.

Also, we move the decision of whether to regenerate a file or not to the
user (instead of checking if we should generate the file again or not).

See #2350
@matiasgarciaisaia
Trigger files generation
45976ae 
From the UI, request that the CSV files are generated by the backend.

We still miss checking if the files exist or are currently being
generated.

See #2350
@matiasgarciaisaia
Statically serve the generated files
f0567f4 
See #2350
@matiasgarciaisaia
Add file status endpoint
c20bf93 
See #2350
@matiasgarciaisaia
Make API return a map of files instead of an array
a2fa8a1 
See #2350
@matiasgarciaisaia
Fetch files status upon Downloads dialog load
3137cba 
See #2350
@matiasgarciaisaia
Fetch files status upon download dialog
ceb100d 
See #2350
@matiasgarciaisaia
Enable/disable file buttons depending on state
31169b7 
See #2350
@matiasgarciaisaia
Regularly fetch respondent files status
a5dda9b 
See #2350
@matiasgarciaisaia
Fix SurveyResults tests
59e67b7 
Small changes, nothing too relevant.

See #2350
@matiasgarciaisaia
Fixing FlowJS typing
20d0720 
There's probably still an issue with react-timeago not being properly
ignored yet.

See #2350
@matiasgarciaisaia
Ignore Flow-typing react-timeago
05db608 
There are no definitions available.

See #2350
@matiasgarciaisaia
Remove unused variables
b17c050 
Thanks, eslint!

See #2350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anaPerezGhiglia @matiasgarciaisaia