Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2350: Generate survey files async #2362

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

#2350: Generate survey files async #2362

wants to merge 33 commits into from

Commits on Aug 13, 2024

  1. create SurveyFilesManager actor to handle generation of files

    @anaPerezGhiglia @matiasgarciaisaia
    anaPerezGhiglia authored and matiasgarciaisaia committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    86648c7 View commit details
    Browse the repository at this point in the history

  2. Generate interactions file into a new dir

    @anaPerezGhiglia @matiasgarciaisaia
    anaPerezGhiglia authored and matiasgarciaisaia committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    610b742 View commit details
    Browse the repository at this point in the history

  3. add basic decision for generating file or not

    @anaPerezGhiglia @matiasgarciaisaia
    anaPerezGhiglia authored and matiasgarciaisaia committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2a05f87 View commit details
    Browse the repository at this point in the history

  4. Add incentives file to SurveyFilesManager

    @anaPerezGhiglia @matiasgarciaisaia
    anaPerezGhiglia authored and matiasgarciaisaia committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    383a4c3 View commit details
    Browse the repository at this point in the history

  5. add disposition_history files to SurveyFilesManager

    @anaPerezGhiglia @matiasgarciaisaia
    anaPerezGhiglia authored and matiasgarciaisaia committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    55dd067 View commit details
    Browse the repository at this point in the history

  6. Convert csv trigger request into POST requests with no csv format

    @anaPerezGhiglia @matiasgarciaisaia
    anaPerezGhiglia authored and matiasgarciaisaia committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d07a31c View commit details
    Browse the repository at this point in the history

  7. add respondents_result file to SurveyFilesManager

    @anaPerezGhiglia @matiasgarciaisaia
    anaPerezGhiglia authored and matiasgarciaisaia committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    074e3f0 View commit details
    Browse the repository at this point in the history

  8. Cleanup

    @anaPerezGhiglia @matiasgarciaisaia
    anaPerezGhiglia authored and matiasgarciaisaia committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e7932f0 View commit details
    Browse the repository at this point in the history

  9. Fix router path to point to new get_respondents_result path

    @anaPerezGhiglia @matiasgarciaisaia
    anaPerezGhiglia authored and matiasgarciaisaia committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    ee47361 View commit details
    Browse the repository at this point in the history

  10. Remove respondents_where from Survey model

    @anaPerezGhiglia @matiasgarciaisaia
    anaPerezGhiglia authored and matiasgarciaisaia committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d303147 View commit details
    Browse the repository at this point in the history

  11. Rename Ask.Runtime.SurveyFilesManager to Ask.SurveyResults

    @anaPerezGhiglia @matiasgarciaisaia
    anaPerezGhiglia authored and matiasgarciaisaia committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    5ff4cee View commit details
    Browse the repository at this point in the history

  12. Move all_questionnaires_fields to SurveyResults 

    instead of Questionnaire
    @anaPerezGhiglia @matiasgarciaisaia
    anaPerezGhiglia authored and matiasgarciaisaia committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    adea7e4 View commit details
    Browse the repository at this point in the history

  13. remove unused import

    @anaPerezGhiglia @matiasgarciaisaia
    anaPerezGhiglia authored and matiasgarciaisaia committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    931a236 View commit details
    Browse the repository at this point in the history

  14. Scaffold Survey Results tests 

    See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    4027e03 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. More tests

    @matiasgarciaisaia
    matiasgarciaisaia committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e16a77b View commit details
    Browse the repository at this point in the history

  2. Keep moving tests 

    See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    0e900c4 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Make test suite "pass" by skipping broken tests 

    We should un-skip them by the end of the PR.

See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    02a9384 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. File downloads UI - first take 

    The info about the generated files is still pending.

See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ed988f8 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Stub downloading previously generated result files 

    See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    607b382 View commit details
    Browse the repository at this point in the history

  2. Typo 

    See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b72c41a View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Generate async files in a stable path 

    This will allow us to check if there already is a file generated or not.

Also, we move the decision of whether to regenerate a file or not to the
user (instead of checking if we should generate the file again or not).

See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b130c76 View commit details
    Browse the repository at this point in the history

  2. Trigger files generation 

    From the UI, request that the CSV files are generated by the backend.

We still miss checking if the files exist or are currently being
generated.

See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    45976ae View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Statically serve the generated files 

    See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    f0567f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Add file status endpoint 

    See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c20bf93 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Make API return a map of files instead of an array 

    See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    a2fa8a1 View commit details
    Browse the repository at this point in the history

  2. Fetch files status upon Downloads dialog load 

    See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    3137cba View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Fetch files status upon download dialog 

    See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ceb100d View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Enable/disable file buttons depending on state 

    See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    31169b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Regularly fetch respondent files status 

    See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a5dda9b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Fix SurveyResults tests 

    Small changes, nothing too relevant.

See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    59e67b7 View commit details
    Browse the repository at this point in the history

  2. Fixing FlowJS typing 

    There's probably still an issue with react-timeago not being properly
ignored yet.

See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    20d0720 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Ignore Flow-typing react-timeago 

    There are no definitions available.

See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    05db608 View commit details
    Browse the repository at this point in the history

  2. Remove unused variables 

    Thanks, eslint!

See #2350
    @matiasgarciaisaia
    matiasgarciaisaia committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b17c050 View commit details
    Browse the repository at this point in the history