Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ray): use dict instead of protobuf message #178

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix(ray): use dict instead of protobuf message #178

merged 1 commit into from
Jul 22, 2024

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Jul 22, 2024

Because

  • The generated field names for protobuf message does not aligned between golang and python
  • Task protobuf definitions are going to be retired

This commit

  • use MessageToDict instead to parse task inputs

@heiruwu heiruwu requested a review from joremysh as a code owner July 22, 2024 18:29
@heiruwu heiruwu merged commit 3277488 into main Jul 22, 2024
8 checks passed
@heiruwu heiruwu deleted the use-dict branch July 22, 2024 18:31
@droplet-bot droplet-bot mentioned this pull request Jul 22, 2024
Merged
heiruwu added a commit that referenced this pull request Aug 7, 2024
@heiruwu
fix(ray): use dict instead of protobuf message (#178)
facd7d9 
Because

- The generated field names for protobuf message does not aligned
between golang and python
- Task protobuf definitions are going to be retired

This commit

- use `MessageToDict` instead to parse task inputs
heiruwu added a commit that referenced this pull request Sep 3, 2024
@heiruwu
fix(ray): use dict instead of protobuf message (#178)
932ce54 
Because

- The generated field names for protobuf message does not aligned
between golang and python
- Task protobuf definitions are going to be retired

This commit

- use `MessageToDict` instead to parse task inputs
heiruwu added a commit that referenced this pull request Sep 5, 2024
@heiruwu
fix(ray): use dict instead of protobuf message (#178)
22769e8 
Because

- The generated field names for protobuf message does not aligned
between golang and python
- Task protobuf definitions are going to be retired

This commit

- use `MessageToDict` instead to parse task inputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joremysh joremysh Awaiting requested review from joremysh joremysh is a code owner

Assignees
No one assigned
Labels
instill core
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heiruwu @droplet-bot