Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add e2e test for queue::fill with a range of pattern sizes" #16465

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Dec 23, 2024

Reverts #15991

Its commit message wasn't properly cleaned up, and the test seems to require UNSUPPORTED and not an XFAIL.

@aelovikov-intel aelovikov-intel merged commit 7f9887a into sycl Dec 24, 2024
15 of 16 checks passed
@aelovikov-intel aelovikov-intel deleted the revert-15991-improve-memset branch December 24, 2024 16:07
sarnex pushed a commit to sarnex/llvm that referenced this pull request Dec 24, 2024
…ntel#16465)

Reverts intel#15991 

Its commit message wasn't properly cleaned up, and the test seems to
require `UNSUPPORTED` and not an `XFAIL`.
dm-vodopyanov pushed a commit that referenced this pull request Jan 8, 2025
Add a new e2e test to validate queue::fill outputs for any pattern size
between 1 and 32 bytes.

Backend implementations of this feature commonly branch on the pattern
size to implement an optimized path for specific values. This test
ensures a wide range of cases is tested, including also odd numbers of
bytes.

Re-adds #15991 reverted in #16465 with changes to fix #16434.

---------

Co-authored-by: Udit Kumar Agarwal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants