Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inter Planetarify #240

Merged
merged 56 commits into from
Sep 23, 2022
Merged

Inter Planetarify #240

merged 56 commits into from
Sep 23, 2022

Conversation

femans
Copy link
Contributor

@femans femans commented Sep 16, 2022

Planitarify -

turn the interplanetary filesystem into your personal audio center

Issues:

bugs:

styling:

  • app bar on small screen has too much stuff. Type selector should be in filter dropdown
  • app bar should turn searchbar into magnify-icon and when you click that, go back to search view
  • Search view tiles stretch if text gets too long. Text needs to be cropped
  • responsiveness of major features

features:

@femans femans changed the title Inter Planetify Inter Planetarify Sep 17, 2022
@dokterbob
Copy link
Member

dokterbob commented Sep 20, 2022

Planetarians Unite!

It works over crappy 4G+++

Some issues, none of them blocking a merge (but wise to create issues before merge):

  • Overlap of settings with Planetififififiy
    image

  • This could be a rectangle (stop button) not a cross (close button):
    image

  • This could be the cross/close button:
    image

  • Suggestion: making these amazing buttons less attention-attracting. Specifically; less colour. I feel they distract from content:
    image

Could be something like https://next.vuetifyjs.com/en/components/buttons/#outlined or any of these https://next.vuetifyjs.com/en/components/buttons/#variant

@femans
Copy link
Contributor Author

femans commented Sep 20, 2022

The strategy, I think, is: to launch this feature with along with a communication blast.
Maybe after midi functionality is ready too, so this can be added too.

Note that there are some bugs and Nice To Have features still on the list, which I will turn into issues. These are not blocking the release in my opinion.

@femans femans linked an issue Sep 20, 2022 that may be closed by this pull request
@femans femans marked this pull request as ready for review September 20, 2022 12:04
@Szeket
Copy link
Contributor

Szeket commented Sep 21, 2022

I think it's cool! Very nice feature!
I have few questions though:

Screenshot at 2022-09-21 16-24-51(1)
I think the lines outlining "audio", "documents", "video" etc. are too thick. Could they be thinner and also have the same colour as lines from filters? To somehow refer to it graphically?
Screenshot at 2022-09-21 16-33-15
This song is gray once I listen to it?
Screenshot at 2022-09-21 16-32-22
Why do I get this error? Any ideas?

I am not a big fan of the violet background colour. I think the ipfs-search.com theme is blue-gray, so maybe we can make this colour a bit less intense and more relating to the theme palette?

@dokterbob
Copy link
Member

dokterbob commented Sep 21, 2022

Quick last review, all suggestions are purely optional:

  • Instead of blinking play button, change the play button into a pause button for the currently playing item in the list.
    image

  • The back button doesn't go to the previous track. Rather, it starts the same song again.
    image

  • Not sure whether a stop button is necessary at all. How is the functionality different from the stop button?
    image

  • It would be so fucking awesome if clicking on an artist's name or an album would link to the search results for that artist or album, exactly like the metadata search.

  • Palette-wise, @Szeket has a point. The purple is quite intense. Perhaps we can use one of the lighter colours from theme.js?

  • The difference in the border which @Szeket mentioned seems to be a difference in colour. The filters have a hover to black and are lighter. It would indeed be great to have them behave similarly to the filters (include the hover, actually).

@femans
Copy link
Contributor Author

femans commented Sep 21, 2022

@Szeket

I think it's cool! Very nice feature! I have few questions though:

I think the lines outlining "audio", "documents", "video" etc. are too thick. Could they be thinner and also have the same colour as lines from filters? To somehow refer to it graphically?

Matter of opinion. They are the minimum width, 1px, and I like them. They have the ipfsPrimary color. Maybe the filters should be made to match this. Idk.

This song is gray once I listen to it?

The song is grey if there is an error, usually it does not load or it has an unplayable format. Probably should indicate this better with a warning icon/error tooltip, we should make an issue of this.

Why do I get this error? Any ideas?

Yeah it is a bug and it has been reported already ,#241
I may fix it still after I am a bit ahead with the other projects.

I am not a big fan of the violet background colour. I think the ipfs-search.com theme is blue-gray, so maybe we can make this colour a bit less intense and more relating to the theme palette?

Again, matter of opinion, but I wanted something more alive and fun than black (which it was first) or those greyish colors. Also I wanted to let it stand out a bit by itself, like you go to a different realm or app within ipfs-search.com. So I looked for deep purple. I can try looking for a deeper shade of purple, if it is still too much, but I did try it on different screens with different color settings.

I really hate having this kinds of conversations inside the PR. Maybe we can do this in chat or email or something. Thanks for the feedback though!

@femans
Copy link
Contributor Author

femans commented Sep 21, 2022

@femans

  • Not sure whether a stop button is necessary at all. How is the functionality different from the stop button?

It is no different than the stop button because it is the stop button... I am sure I am not understanding the question.

Sorry, I meant to remove the stop button if the pause button has identical behaviour.

  • It would be so fucking awesome if clicking on an artist's name or an album would link to the search results for that artist or album, exactly like the metadata search.

There is a little disc icon on the right that brings you to detail view of that song. From that detail view, metadata search works. We could look for a more indicative icon, so it is easier to find. But no, I don't think we should put metadata search directly into the playlist, that gets too crammed.

I had not even noticed this was a thing to click on, nor that it was a disc. (Note that a significant part of our audience has never soon one!) Perhaps we can use a different icon for the detail view?

Suggestions:

  1. mDi file-find image
  2. mDi file-document image
  3. mDi folder-information and information
    image
  4. mDi information-variant
    image

My suggestion is not to add any UI element, merely to turn the existing text of the artist name and album into links to all items with the same artist or artist-album. It is not at all a problem to do this after merging this, but seemed little extra work at this time.

@femans femans changed the base branch from master to staging September 22, 2022 11:20
Copy link
Member

@dokterbob dokterbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking issue

Freeze when selecting audio from home page

(Tested on 5eac544 as well as pre-rebase 1ef1bac)
When on home page, click on the search button or select any type but images (no need to enter a search query, but doing so results in the same behaviour).
image

Now the site freezes (the spinner is not running):
image

image

@femans
Copy link
Contributor Author

femans commented Sep 22, 2022

fixed the blocking issue

@femans femans linked an issue Sep 22, 2022 that may be closed by this pull request
@femans femans merged commit d7b33fb into staging Sep 23, 2022
@femans femans deleted the feature/playlist branch September 23, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants