-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inter Planetarify #240
Inter Planetarify #240
Conversation
Planetarians Unite!It works over crappy 4G+++ Some issues, none of them blocking a merge (but wise to create issues before merge):
Could be something like https://next.vuetifyjs.com/en/components/buttons/#outlined or any of these https://next.vuetifyjs.com/en/components/buttons/#variant |
The strategy, I think, is: to launch this feature with along with a communication blast. Note that there are some bugs and Nice To Have features still on the list, which I will turn into issues. These are not blocking the release in my opinion. |
Quick last review, all suggestions are purely optional:
|
Matter of opinion. They are the minimum width, 1px, and I like them. They have the ipfsPrimary color. Maybe the filters should be made to match this. Idk.
The song is grey if there is an error, usually it does not load or it has an unplayable format. Probably should indicate this better with a warning icon/error tooltip, we should make an issue of this.
Yeah it is a bug and it has been reported already ,#241
Again, matter of opinion, but I wanted something more alive and fun than black (which it was first) or those greyish colors. Also I wanted to let it stand out a bit by itself, like you go to a different realm or app within ipfs-search.com. So I looked for deep purple. I can try looking for a deeper shade of purple, if it is still too much, but I did try it on different screens with different color settings. I really hate having this kinds of conversations inside the PR. Maybe we can do this in chat or email or something. Thanks for the feedback though! |
Sorry, I meant to remove the stop button if the pause button has identical behaviour.
I had not even noticed this was a thing to click on, nor that it was a disc. (Note that a significant part of our audience has never soon one!) Perhaps we can use a different icon for the detail view? Suggestions: My suggestion is not to add any UI element, merely to turn the existing text of the artist name and album into links to all items with the same artist or artist-album. It is not at all a problem to do this after merging this, but seemed little extra work at this time. |
1ef1bac
to
5eac544
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking issue
Freeze when selecting audio from home page
(Tested on 5eac544 as well as pre-rebase 1ef1bac)
When on home page, click on the search button or select any type but images (no need to enter a search query, but doing so results in the same behaviour).
fixed the blocking issue |
…s playing. Better loading indicator
379455f
to
1175341
Compare
Planitarify -
turn the interplanetary filesystem into your personal audio center
Issues:
bugs:
styling:
features: